Merged
Conversation
SteveMacenski
requested changes
Jul 1, 2024
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Overall looks good, just some details. Can you submit this over to Nav2 as well? That way its in Jazzy and Rolling as well
https://github.com/ros-navigation/navigation2/tree/main/nav2_docking
Contributor
Author
|
Implemented requested changes, and opened ros-navigation/navigation2#4511 |
SteveMacenski
approved these changes
Jul 2, 2024
SteveMacenski
added a commit
that referenced
this pull request
Jul 2, 2024
This reverts commit 3fb0491.
Merged
SteveMacenski
added a commit
that referenced
this pull request
Jul 2, 2024
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dock id feature as per #44 .
This PR adds an id field to every dock instance (it can be empty).